circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2025-11-01 15:06:06 +00:00
Code Issues Projects Releases Wiki Activity

Do not realpath() everything since it is pointless and breaks symlinks.

Browse Source 
GitHub issue 4427.
This commit is contained in:
nicm
2025-10-28 10:51:30 +00:00
parent 7cbb96528c
commit b4ba6e49af
2 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cmd-source-file.c
View File

@@ -136,16 +136,7 @@ cmd_source_file_done(struct client *c, const char *path, int error,
static void
cmd_source_file_add(struct cmd_source_file_data *cdata, const char *path)
{
char resolved[PATH_MAX];
if (realpath(path, resolved) == NULL) {
log_debug("%s: realpath(\"%s\") failed: %s", __func__,
path, strerror(errno));
} else
path = resolved;
log_debug("%s: %s", __func__, path);
cdata->files = xreallocarray(cdata->files, cdata->nfiles + 1,
sizeof *cdata->files);
cdata->files[cdata->nfiles++] = xstrdup(path);

16
tmux.c
View File

@@ -143,7 +143,7 @@ expand_path(const char *path, const char *home)
}
static void
expand_paths(const char *s, char ***paths, u_int *n, int ignore_errors)
expand_paths(const char *s, char ***paths, u_int *n, int no_realpath)
{
const char *home = find_home();
char *copy, *next, *tmp, resolved[PATH_MAX], *expanded;
@@ -160,15 +160,15 @@ expand_paths(const char *s, char ***paths, u_int *n, int ignore_errors)
log_debug("%s: invalid path: %s", __func__, next);
continue;
}
if (realpath(expanded, resolved) == NULL) {
log_debug("%s: realpath(\"%s\") failed: %s", __func__,
expanded, strerror(errno));
if (ignore_errors) {
if (no_realpath)
path = expanded;
else {
if (realpath(expanded, resolved) == NULL) {
log_debug("%s: realpath(\"%s\") failed: %s", __func__,
expanded, strerror(errno));
free(expanded);
continue;
}
path = expanded;
} else {
path = xstrdup(resolved);
free(expanded);
}
@@ -200,7 +200,7 @@ make_label(const char *label, char **cause)
label = "default";
uid = getuid();
expand_paths(TMUX_SOCK, &paths, &n, 1);
expand_paths(TMUX_SOCK, &paths, &n, 0);
if (n == 0) {
xasprintf(cause, "no suitable socket path");
return (NULL);