mirror of
				https://github.com/tmux/tmux.git
				synced 2025-11-04 00:56:10 +00:00 
			
		
		
		
	Add a command queue to standardize and simplify commands that call other
commands and allow a command to block execution of subsequent commands. This allows run-shell and if-shell to be synchronous which has been much requested. Each client has a default command queue and commands are consumed one at a time from it. A command may suspend execution from the queue by returning CMD_RETURN_WAIT and then resume it by calling cmd_continue() - for example run-shell does this from the callback that is fired after the job is freed. When the command queue becomes empty, command clients are automatically exited (unless attaching). A callback is also fired - this is used for nested commands in, for example, if-shell which can block execution of the client's cmdq until a new cmdq becomes empty. Also merge all the old error/info/print functions together and lose the old curclient/cmdclient distinction - a cmdq is bound to one client (or none if in the configuration file), this is a command client if c->session is NULL otherwise an attached client.
This commit is contained in:
		@@ -29,15 +29,16 @@
 | 
			
		||||
 * Executes a tmux command if a shell command returns true or false.
 | 
			
		||||
 */
 | 
			
		||||
 | 
			
		||||
enum cmd_retval	 cmd_if_shell_exec(struct cmd *, struct cmd_ctx *);
 | 
			
		||||
enum cmd_retval	 cmd_if_shell_exec(struct cmd *, struct cmd_q *);
 | 
			
		||||
 | 
			
		||||
void	cmd_if_shell_callback(struct job *);
 | 
			
		||||
void	cmd_if_shell_done(struct cmd_q *);
 | 
			
		||||
void	cmd_if_shell_free(void *);
 | 
			
		||||
 | 
			
		||||
const struct cmd_entry cmd_if_shell_entry = {
 | 
			
		||||
	"if-shell", "if",
 | 
			
		||||
	"t:", 2, 3,
 | 
			
		||||
	CMD_TARGET_PANE_USAGE " shell-command command [command]",
 | 
			
		||||
	"bt:", 2, 3,
 | 
			
		||||
	"[-b] " CMD_TARGET_PANE_USAGE " shell-command command [command]",
 | 
			
		||||
	0,
 | 
			
		||||
	NULL,
 | 
			
		||||
	NULL,
 | 
			
		||||
@@ -47,11 +48,13 @@ const struct cmd_entry cmd_if_shell_entry = {
 | 
			
		||||
struct cmd_if_shell_data {
 | 
			
		||||
	char		*cmd_if;
 | 
			
		||||
	char		*cmd_else;
 | 
			
		||||
	struct cmd_ctx	*ctx;
 | 
			
		||||
	struct cmd_q	*cmdq;
 | 
			
		||||
	int		 bflag;
 | 
			
		||||
	int		 started;
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
enum cmd_retval
 | 
			
		||||
cmd_if_shell_exec(struct cmd *self, struct cmd_ctx *ctx)
 | 
			
		||||
cmd_if_shell_exec(struct cmd *self, struct cmd_q *cmdq)
 | 
			
		||||
{
 | 
			
		||||
	struct args			*args = self->args;
 | 
			
		||||
	struct cmd_if_shell_data	*cdata;
 | 
			
		||||
@@ -61,7 +64,7 @@ cmd_if_shell_exec(struct cmd *self, struct cmd_ctx *ctx)
 | 
			
		||||
	struct window_pane		*wp;
 | 
			
		||||
	struct format_tree		*ft;
 | 
			
		||||
 | 
			
		||||
	wl = cmd_find_pane(ctx, args_get(args, 't'), &s, &wp);
 | 
			
		||||
	wl = cmd_find_pane(cmdq, args_get(args, 't'), &s, &wp);
 | 
			
		||||
	if (wl == NULL)
 | 
			
		||||
		return (CMD_RETURN_ERROR);
 | 
			
		||||
 | 
			
		||||
@@ -78,51 +81,83 @@ cmd_if_shell_exec(struct cmd *self, struct cmd_ctx *ctx)
 | 
			
		||||
		cdata->cmd_else = xstrdup(args->argv[2]);
 | 
			
		||||
	else
 | 
			
		||||
		cdata->cmd_else = NULL;
 | 
			
		||||
	cdata->bflag = args_has(args, 'b');
 | 
			
		||||
 | 
			
		||||
	cdata->ctx = ctx;
 | 
			
		||||
	cmd_ref_ctx(ctx);
 | 
			
		||||
	cdata->started = 0;
 | 
			
		||||
	cdata->cmdq = cmdq;
 | 
			
		||||
	cmdq->references++;
 | 
			
		||||
 | 
			
		||||
	job_run(shellcmd, cmd_if_shell_callback, cmd_if_shell_free, cdata);
 | 
			
		||||
	free(shellcmd);
 | 
			
		||||
 | 
			
		||||
	return (CMD_RETURN_YIELD);	/* don't let client exit */
 | 
			
		||||
	if (cdata->bflag)
 | 
			
		||||
		return (CMD_RETURN_NORMAL);
 | 
			
		||||
	return (CMD_RETURN_WAIT);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void
 | 
			
		||||
cmd_if_shell_callback(struct job *job)
 | 
			
		||||
{
 | 
			
		||||
	struct cmd_if_shell_data	*cdata = job->data;
 | 
			
		||||
	struct cmd_ctx			*ctx = cdata->ctx;
 | 
			
		||||
	struct cmd_q			*cmdq = cdata->cmdq, *cmdq1;
 | 
			
		||||
	struct cmd_list			*cmdlist;
 | 
			
		||||
	char				*cause, *cmd;
 | 
			
		||||
 | 
			
		||||
	if (!WIFEXITED(job->status) || WEXITSTATUS(job->status) != 0) {
 | 
			
		||||
	if (cmdq->dead)
 | 
			
		||||
		return;
 | 
			
		||||
 | 
			
		||||
	if (!WIFEXITED(job->status) || WEXITSTATUS(job->status) != 0)
 | 
			
		||||
		cmd = cdata->cmd_else;
 | 
			
		||||
		if (cmd == NULL)
 | 
			
		||||
			return;
 | 
			
		||||
	} else
 | 
			
		||||
	else
 | 
			
		||||
		cmd = cdata->cmd_if;
 | 
			
		||||
	if (cmd_string_parse(cmd, &cmdlist, &cause) != 0) {
 | 
			
		||||
	if (cmd == NULL)
 | 
			
		||||
		return;
 | 
			
		||||
 | 
			
		||||
	if (cmd_string_parse(cmd, &cmdlist, NULL, 0, &cause) != 0) {
 | 
			
		||||
		if (cause != NULL) {
 | 
			
		||||
			ctx->error(ctx, "%s", cause);
 | 
			
		||||
			cmdq_error(cmdq, "%s", cause);
 | 
			
		||||
			free(cause);
 | 
			
		||||
		}
 | 
			
		||||
		return;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	cmd_list_exec(cmdlist, ctx);
 | 
			
		||||
	cdata->started = 1;
 | 
			
		||||
 | 
			
		||||
	cmdq1 = cmdq_new(cmdq->client);
 | 
			
		||||
	cmdq1->emptyfn = cmd_if_shell_done;
 | 
			
		||||
	cmdq1->data = cdata;
 | 
			
		||||
 | 
			
		||||
	cmdq_run(cmdq1, cmdlist);
 | 
			
		||||
	cmd_list_free(cmdlist);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void
 | 
			
		||||
cmd_if_shell_done(struct cmd_q *cmdq1)
 | 
			
		||||
{
 | 
			
		||||
	struct cmd_if_shell_data	*cdata = cmdq1->data;
 | 
			
		||||
	struct cmd_q			*cmdq = cdata->cmdq;
 | 
			
		||||
 | 
			
		||||
	if (!cmdq_free(cmdq) && !cdata->bflag)
 | 
			
		||||
		cmdq_continue(cmdq);
 | 
			
		||||
 | 
			
		||||
	cmdq_free(cmdq1);
 | 
			
		||||
 | 
			
		||||
	free(cdata->cmd_else);
 | 
			
		||||
	free(cdata->cmd_if);
 | 
			
		||||
	free(cdata);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
void
 | 
			
		||||
cmd_if_shell_free(void *data)
 | 
			
		||||
{
 | 
			
		||||
	struct cmd_if_shell_data	*cdata = data;
 | 
			
		||||
	struct cmd_ctx			*ctx = cdata->ctx;
 | 
			
		||||
	struct cmd_q			*cmdq = cdata->cmdq;
 | 
			
		||||
 | 
			
		||||
	if (ctx->cmdclient != NULL)
 | 
			
		||||
		ctx->cmdclient->flags |= CLIENT_EXIT;
 | 
			
		||||
	cmd_free_ctx(ctx);
 | 
			
		||||
	if (cdata->started)
 | 
			
		||||
		return;
 | 
			
		||||
 | 
			
		||||
	if (!cmdq_free(cmdq) && !cdata->bflag)
 | 
			
		||||
		cmdq_continue(cmdq);
 | 
			
		||||
 | 
			
		||||
	free(cdata->cmd_else);
 | 
			
		||||
	free(cdata->cmd_if);
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user