tmux-plugins/tmux-resurrect
1
0
Fork 0
mirror of https://github.com/tmux-plugins/tmux-resurrect.git synced 2025-09-03 22:17:01 +00:00
Code Issues Projects Releases Wiki Activity

Deprecate restoring shell history

Browse Source 
"restoring shell history" feature is very invasive and dirty. I propose
removing it in the future without the replacement.

I worry it spoils the first experience of using this plugin for users
that accidentally turn it on and don't know how to turn it off, see
https://github.com/tmux-plugins/tmux-resurrect/issues/288

Also, it hurts me to reject PRs that improve the feature.

Thoughts?
This commit is contained in:
Bruno Sutic
2019-08-27 13:26:29 +02:00
parent e3f05dd34f
commit d7825683d1
5 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/hooks.md
View File

@ -20,7 +20,7 @@ Currently the following hooks are supported:
Called before any tmux state is altered.
- `@resurrect-hook-pre-restore-history`
- `@resurrect-hook-pre-restore-history` - deprecated
Called after panes and layout have been restores, but before bash history is
restored (if it is enabled) -- the hook is always called even if history

6
docs/restoring_shell_history.md
View File

@ -1,4 +1,8 @@
# Restoring shell history (experimental)
# Restoring shell history (deprecated, do not use)
This feature is deprecated because it's very invasive. It will be removed in
the future with no replacement. To see problems it causes check
[this issue](https://github.com/tmux-plugins/tmux-resurrect/issues/288).
**Supported shells**: `bash` and `zsh`.