From ff4b4e667a64b30e4323df4b0e1637fc7ebae6c1 Mon Sep 17 00:00:00 2001
From: Nicholas Marriott <nicm@openbsd.org>
Date: Sun, 11 Oct 2009 07:20:16 +0000
Subject: [PATCH] Collect status from dead jobs and don't invoke the callback
 until both all input (the socket is closed) and status is available.

---
 job.c    |  5 ++++-
 server.c | 32 +++++++++++++++++++++++++++-----
 tmux.h   |  4 ++++
 3 files changed, 35 insertions(+), 6 deletions(-)

diff --git a/job.c b/job.c
index 53b05bb4..df515b37 100644
--- a/job.c
+++ b/job.c
@@ -105,6 +105,8 @@ job_add(struct jobs *jobs, struct client *c, const char *cmd,
 	job->freefn = freefn;
 	job->data = data;
 
+	job->flags = JOB_DONE;
+
 	RB_INSERT(jobs, jobs, job);
 	SLIST_INSERT_HEAD(&all_jobs, job, lentry);
 	
@@ -133,8 +135,9 @@ job_run(struct job *job)
 {
 	int	nullfd, out[2], mode;
 
-	if (job->fd != -1)
+	if (!(job->flags & JOB_DONE))
 		return (0);
+	job->flags &= ~JOB_DONE;
 
 	if (pipe(out) != 0)
 		return (-1);
diff --git a/server.c b/server.c
index cff3db3b..d19b321d 100644
--- a/server.c
+++ b/server.c
@@ -88,6 +88,7 @@ void	 	 server_check_window(struct window *);
 void		 server_check_redraw(struct client *);
 void		 server_set_title(struct client *);
 void		 server_check_timers(struct client *);
+void		 server_check_jobs(void);
 void		 server_lock_server(void);
 void		 server_lock_sessions(void);
 void		 server_check_clients(void);
@@ -370,7 +371,8 @@ server_main(int srv_fd)
 			sigusr1 = 0;
 		}
 
-		/* Process client actions. */
+		/* Collect any jobs that have died and process clients. */
+		server_check_jobs();
 		server_check_clients();
 
 		/* Initialise pollfd array and add server socket. */
@@ -389,7 +391,6 @@ server_main(int srv_fd)
 
 		/* Do the poll. */
 		pfds = server_poll_flatten(&nfds);
-		log_debug("polling %d", nfds);
 		if (poll(pfds, nfds, xtimeout) == -1) {
 			if (errno == EAGAIN || errno == EINTR)
 				continue;
@@ -510,6 +511,7 @@ server_child_signal(void)
 {
 	struct window		*w;
 	struct window_pane	*wp;
+	struct job		*job;
 	int		 	 status;
 	pid_t		 	 pid;
 	u_int		 	 i;
@@ -523,8 +525,15 @@ server_child_signal(void)
 		case 0:
 			return;
 		}
-		if (!WIFSTOPPED(status))
+		if (!WIFSTOPPED(status)) {
+			SLIST_FOREACH(job, &all_jobs, lentry) {
+				if (pid == job->pid) {
+					job->pid = -1;
+					job->status = status;
+				}
+			}
 			continue;
+		}
 		if (WSTOPSIG(status) == SIGTTIN || WSTOPSIG(status) == SIGTTOU)
 			continue;
 
@@ -792,12 +801,25 @@ server_handle_jobs(void)
 		if (buffer_poll(pfd, job->out, NULL) != 0) {
 			close(job->fd);
 			job->fd = -1;
-			if (job->callbackfn != NULL)
-				job->callbackfn(job);
 		}
 	}
 }
 
+/* Handle job fds. */
+void
+server_check_jobs(void)
+{
+	struct job	*job;
+
+	SLIST_FOREACH(job, &all_jobs, lentry) {
+		if (job->flags & JOB_DONE || job->fd != -1 || job->pid != -1)
+			continue;
+		if (job->callbackfn != NULL)
+			job->callbackfn(job);
+		job->flags |= JOB_DONE;
+	}
+}
+
 /* Handle client pollfds. */
 void
 server_handle_clients(void)
diff --git a/tmux.h b/tmux.h
index 71b307fb..a975dca3 100644
--- a/tmux.h
+++ b/tmux.h
@@ -567,6 +567,7 @@ ARRAY_DECL(keylist, int);
 struct job {
 	char		*cmd;
 	pid_t		 pid;
+	int		 status;
 
 	struct client	*client;
 
@@ -577,6 +578,9 @@ struct job {
 	void		(*freefn)(void *);
 	void		*data;
 
+	int		 flags;
+#define JOB_DONE 0x1
+
 	RB_ENTRY(job)	 entry;
 	SLIST_ENTRY(job) lentry;
 };