circlecloud
/
tmux
mirror of https://github.com/tmux/tmux.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Drop tiny union from option struct.

pull/1/head
Nicholas Marriott 2009-09-21 07:00:09 +00:00
parent c7a8db5543
commit fc9107a16a
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
options.c
View File

@ -53,7 +53,7 @@ options_free(struct options *oo)
SPLAY_REMOVE(options_tree, &oo->tree, o); SPLAY_REMOVE(options_tree, &oo->tree, o);
xfree(o->name); xfree(o->name);
if (o->type == OPTIONS_STRING) if (o->type == OPTIONS_STRING)
xfree(o->value.string); xfree(o->str);
xfree(o); xfree(o);
} }
} }
@ -94,7 +94,7 @@ options_remove(struct options *oo, const char *name)
SPLAY_REMOVE(options_tree, &oo->tree, o); SPLAY_REMOVE(options_tree, &oo->tree, o);
xfree(o->name); xfree(o->name);
if (o->type == OPTIONS_STRING) if (o->type == OPTIONS_STRING)
xfree(o->value.string); xfree(o->str);
xfree(o); xfree(o);
} }
@ -109,11 +109,11 @@ options_set_string(struct options *oo, const char *name, const char *fmt, ...)
o->name = xstrdup(name); o->name = xstrdup(name);
SPLAY_INSERT(options_tree, &oo->tree, o); SPLAY_INSERT(options_tree, &oo->tree, o);
} else if (o->type == OPTIONS_STRING) } else if (o->type == OPTIONS_STRING)
xfree(o->value.string); xfree(o->str);
va_start(ap, fmt); va_start(ap, fmt);
o->type = OPTIONS_STRING; o->type = OPTIONS_STRING;
xvasprintf(&o->value.string, fmt, ap); xvasprintf(&o->str, fmt, ap);
va_end(ap); va_end(ap);
} }
@ -126,7 +126,7 @@ options_get_string(struct options *oo, const char *name)
fatalx("missing option"); fatalx("missing option");
if (o->type != OPTIONS_STRING) if (o->type != OPTIONS_STRING)
fatalx("option not a string"); fatalx("option not a string");
return (o->value.string); return (o->str);
} }
void void
@ -139,10 +139,10 @@ options_set_number(struct options *oo, const char *name, long long value)
o->name = xstrdup(name); o->name = xstrdup(name);
SPLAY_INSERT(options_tree, &oo->tree, o); SPLAY_INSERT(options_tree, &oo->tree, o);
} else if (o->type == OPTIONS_STRING) } else if (o->type == OPTIONS_STRING)
xfree(o->value.string); xfree(o->str);
o->type = OPTIONS_NUMBER; o->type = OPTIONS_NUMBER;
o->value.number = value; o->num = value;
} }
@ -155,5 +155,5 @@ options_get_number(struct options *oo, const char *name)
fatalx("missing option"); fatalx("missing option");
if (o->type != OPTIONS_NUMBER) if (o->type != OPTIONS_NUMBER)
fatalx("option not a number"); fatalx("option not a number");
return (o->value.number); return (o->num);
} }

7
tmux.h
View File

@ -545,10 +545,9 @@ struct options_entry {
OPTIONS_STRING, OPTIONS_STRING,
OPTIONS_NUMBER, OPTIONS_NUMBER,
} type; } type;
union {
char *string; char *str;
long long number; long long num;
} value;
SPLAY_ENTRY(options_entry) entry; SPLAY_ENTRY(options_entry) entry;
}; };