circlecloud
/
tmux
mirror of https://github.com/tmux/tmux.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Do not lazily use BUFSIZ for "I don't care what size" when building 

strings because it is only guaranteed to be 256 bytes and even the
default 1024 is not always enough. Reported by Gregory Pakosz.
pull/1933/head
nicm 2019-10-03 10:24:05 +00:00
parent bbd1032a2a
commit f4c7141f5d
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd-list-keys.c
View File

@ -61,7 +61,7 @@ cmd_list_keys_exec(struct cmd *self, struct cmdq_item *item)
struct key_table *table;
struct key_binding *bd;
const char *tablename, *r;
char *key, *cp, tmp[BUFSIZ];
char *key, *cp, tmp[8192];
int repeat, width, tablewidth, keywidth;
if (self->entry == &cmd_list_commands_entry)

4
cmd-parse.y
View File

@ -1245,7 +1245,7 @@ yylex_token_variable(char **buf, size_t *len)
{
struct environ_entry *envent;
int ch, brackets = 0;
char name[BUFSIZ];
char name[1024];
size_t namelen = 0;
const char *value;
@ -1297,7 +1297,7 @@ yylex_token_tilde(char **buf, size_t *len)
{
struct environ_entry *envent;
int ch;
char name[BUFSIZ];
char name[1024];
size_t namelen = 0;
struct passwd *pw;
const char *home = NULL;

2
cmd.c
View File

@ -385,7 +385,7 @@ cmd_find(const char *name, char **cause)
{
const struct cmd_entry **loop, *entry, *found = NULL;
int ambiguous;
char s[BUFSIZ];
char s[8192];
ambiguous = 0;
for (loop = cmd_table; *loop != NULL; loop++) {

2
layout-custom.c
View File

@ -60,7 +60,7 @@ layout_checksum(const char *layout)
char *
layout_dump(struct layout_cell *root)
{
char layout[BUFSIZ], *out;
char layout[8192], *out;
*layout = '\0';
if (layout_append(root, layout, sizeof layout) != 0)

4
tty-term.c
View File

@ -278,7 +278,7 @@ static char *
tty_term_strip(const char *s)
{
const char *ptr;
static char buf[BUFSIZ];
static char buf[8192];
size_t len;
/* Ignore strings with no padding. */
@ -306,7 +306,7 @@ tty_term_strip(const char *s)
static char *
tty_term_override_next(const char *s, size_t *offset)
{
static char value[BUFSIZ];
static char value[8192];
size_t n = 0, at = *offset;
if (s[at] == '\0')