circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2025-04-02 22:08:49 +00:00
Code Issues Projects Releases Wiki Activity

Do not rely on errno after glob(3) fails.

Browse Source
This commit is contained in:
nicm 2019-12-18 07:48:56 +00:00
parent f8cb759bdb
commit ef54a08080
1 changed files with 10 additions and 4 deletions

14
cmd-source-file.c
View File

@ -130,7 +130,7 @@ cmd_source_file_exec(struct cmd *self, struct cmdq_item *item)
char *pattern, *cwd; char *pattern, *cwd;
const char *path, *error; const char *path, *error;
glob_t g; glob_t g;
int i; int i, result;
u_int j; u_int j;
cdata = xcalloc(1, sizeof *cdata); cdata = xcalloc(1, sizeof *cdata);
@ -158,9 +158,15 @@ cmd_source_file_exec(struct cmd *self, struct cmdq_item *item)
xasprintf(&pattern, "%s/%s", cwd, path); xasprintf(&pattern, "%s/%s", cwd, path);
log_debug("%s: %s", __func__, pattern); log_debug("%s: %s", __func__, pattern);
if (glob(pattern, 0, NULL, &g) != 0) { if ((result = glob(pattern, 0, NULL, &g)) != 0) {
error = strerror(errno); if (result != GLOB_NOMATCH ||
if (errno != ENOENT || (~flags & CMD_PARSE_QUIET)) { (~flags & CMD_PARSE_QUIET)) {
if (result == GLOB_NOMATCH)
error = strerror(ENOENT);
else if (result == GLOB_NOSPACE)
error = strerror(ENOMEM);
else
error = strerror(EINVAL);
cmdq_error(item, "%s: %s", path, error); cmdq_error(item, "%s: %s", path, error);
retval = CMD_RETURN_ERROR; retval = CMD_RETURN_ERROR;
} }