circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2025-11-04 00:56:10 +00:00
Code Issues Projects Releases Wiki Activity

if-shell doesn't need to queue its error message into a callback, and in

Browse Source 
fact it can't do so because the item it was working with will have been
freed. Reported by Daniel Hahler.
This commit is contained in:
nicm
2017-04-25 11:49:35 +00:00
parent 5172014668
commit eb6fd6ff80
1 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
cmd-if-shell.c
View File

@@ -31,7 +31,6 @@
static enum cmd_retval cmd_if_shell_exec(struct cmd *, struct cmdq_item *); static enum cmd_retval cmd_if_shell_exec(struct cmd *, struct cmdq_item *);
static enum cmd_retval cmd_if_shell_error(struct cmdq_item *, void *);
static void cmd_if_shell_callback(struct job *); static void cmd_if_shell_callback(struct job *);
static void cmd_if_shell_free(void *); static void cmd_if_shell_free(void *);
@@ -138,17 +137,6 @@ cmd_if_shell_exec(struct cmd *self, struct cmdq_item *item)
return (CMD_RETURN_WAIT); return (CMD_RETURN_WAIT);
} }
static enum cmd_retval
cmd_if_shell_error(struct cmdq_item *item, void *data)
{
char *error = data;
cmdq_error(item, "%s", error);
free(error);
return (CMD_RETURN_NORMAL);
}
static void static void
cmd_if_shell_callback(struct job *job) cmd_if_shell_callback(struct job *job)
{ {
@@ -168,10 +156,10 @@ cmd_if_shell_callback(struct job *job)
cmdlist = cmd_string_parse(cmd, file, line, &cause); cmdlist = cmd_string_parse(cmd, file, line, &cause);
if (cmdlist == NULL) { if (cmdlist == NULL) {
if (cause != NULL) if (cause != NULL && cdata->item != NULL)
new_item = cmdq_get_callback(cmd_if_shell_error, cause); cmdq_error(cdata->item, "%s", cause);
else free(cause);
new_item = NULL; new_item = NULL;
} else { } else {
new_item = cmdq_get_command(cmdlist, NULL, &cdata->mouse, 0); new_item = cmdq_get_command(cmdlist, NULL, &cdata->mouse, 0);
cmd_list_free(cmdlist); cmd_list_free(cmdlist);