circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2026-10-11 21:14:21 +00:00
Code Issues Projects Releases Wiki Activity

Fix tiled pane resizing with floating layout cells, reported by Kevin

Browse Source 
Hovsäter.
This commit is contained in:
nicm
2026-08-25 18:38:05 +00:00
committed by tmux update bot
parent 4157b64754
commit b26b240613
1 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
layout.c
View File

@@ -1,4 +1,4 @@
/* $OpenBSD: layout.c,v 1.97 2026/08/20 09:19:24 nicm Exp $ */ /* $OpenBSD: layout.c,v 1.98 2026/08/25 18:38:05 nicm Exp $ */
/* /*
* Copyright (c) 2009 Nicholas Marriott <nicholas.marriott@gmail.com> * Copyright (c) 2009 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -539,6 +539,10 @@ layout_resize_check(struct window *w, struct layout_cell *lc,
status = window_get_pane_status(w); status = window_get_pane_status(w);
/* Floating cells do not take space from the tiled layout. */
if (!layout_cell_is_tiled(lc) && !layout_cell_has_tiled_child(lc))
return (0);
if (lc->type == LAYOUT_WINDOWPANE) { if (lc->type == LAYOUT_WINDOWPANE) {
/* Space available in this cell only. */ /* Space available in this cell only. */
if (type == LAYOUT_LEFTRIGHT) { if (type == LAYOUT_LEFTRIGHT) {
@@ -568,6 +572,9 @@ layout_resize_check(struct window *w, struct layout_cell *lc,
/* Different type: minimum of available space in child cells. */ /* Different type: minimum of available space in child cells. */
minimum = UINT_MAX; minimum = UINT_MAX;
TAILQ_FOREACH(lcchild, &lc->cells, entry) { TAILQ_FOREACH(lcchild, &lc->cells, entry) {
if (!layout_cell_is_tiled(lcchild) &&
!layout_cell_has_tiled_child(lcchild))
continue;
available = layout_resize_check(w, lcchild, type); available = layout_resize_check(w, lcchild, type);
if (available < minimum) if (available < minimum)
minimum = available; minimum = available;
@@ -661,7 +668,7 @@ layout_resize_set_size(struct window *w, struct layout_cell *lc,
/* Find and return the nearest neighbour to a cell in a specific direction. */ /* Find and return the nearest neighbour to a cell in a specific direction. */
static struct layout_cell * static struct layout_cell *
layout_cell_get_neighbour_direction(struct layout_cell *lc, int direction) layout_cell_get_neighbour_dir(struct layout_cell *lc, int direction)
{ {
struct layout_cell *lcn = lc; struct layout_cell *lcn = lc;
@@ -695,9 +702,9 @@ layout_cell_get_neighbour(struct layout_cell *lc)
if (lc == TAILQ_LAST(&lcparent->cells, layout_cells)) if (lc == TAILQ_LAST(&lcparent->cells, layout_cells))
direction = !direction; direction = !direction;
lcother = layout_cell_get_neighbour_direction(lc, direction); lcother = layout_cell_get_neighbour_dir(lc, direction);
if (lcother == NULL) if (lcother == NULL)
lcother = layout_cell_get_neighbour_direction(lc, !direction); lcother = layout_cell_get_neighbour_dir(lc, !direction);
return (lcother); return (lcother);
} }
@@ -860,7 +867,7 @@ layout_resize_pane_to(struct window_pane *wp, enum layout_type type,
size = lc->g.sx; size = lc->g.sx;
else else
size = lc->g.sy; size = lc->g.sy;
if (lc == TAILQ_LAST(&lcparent->cells, layout_cells)) if (layout_cell_is_last_tiled(lc))
change = size - new_size; change = size - new_size;
else else
change = new_size - size; change = new_size - size;
@@ -985,11 +992,11 @@ layout_resize_pane(struct window_pane *wp, enum layout_type type, int change,
if (lcparent == NULL) if (lcparent == NULL)
return; return;
/* If this is the last cell, move back one. */ /* If this is the last tiled cell, move back one. */
if (lc == TAILQ_LAST(&lcparent->cells, layout_cells)) { if (layout_cell_is_last_tiled(lc)) {
do lc = layout_cell_get_neighbour_dir(lc, 0);
lc = TAILQ_PREV(lc, layout_cells, entry); if (lc == NULL)
while (lc->flags & LAYOUT_CELL_FLOATING); return;
} }
layout_resize_layout(wp->window, lc, type, change, opposite); layout_resize_layout(wp->window, lc, type, change, opposite);
@@ -1007,22 +1014,22 @@ layout_resize_pane_grow(struct window *w, struct layout_cell *lc,
lcadd = lc; lcadd = lc;
/* Look towards the tail for a suitable cell for reduction. */ /* Look towards the tail for a suitable cell for reduction. */
lcremove = TAILQ_NEXT(lc, entry); lcremove = layout_cell_get_neighbour_dir(lc, 1);
while (lcremove != NULL) { while (lcremove != NULL) {
size = layout_resize_check(w, lcremove, type); size = layout_resize_check(w, lcremove, type);
if (size > 0) if (size > 0)
break; break;
lcremove = TAILQ_NEXT(lcremove, entry); lcremove = layout_cell_get_neighbour_dir(lcremove, 1);
} }
/* If none found, look towards the head. */ /* If none found, look towards the head. */
if (opposite && lcremove == NULL) { if (opposite && lcremove == NULL) {
lcremove = TAILQ_PREV(lc, layout_cells, entry); lcremove = layout_cell_get_neighbour_dir(lc, 0);
while (lcremove != NULL) { while (lcremove != NULL) {
size = layout_resize_check(w, lcremove, type); size = layout_resize_check(w, lcremove, type);
if (size > 0) if (size > 0)
break; break;
lcremove = TAILQ_PREV(lcremove, layout_cells, entry); lcremove = layout_cell_get_neighbour_dir(lcremove, 0);
} }
} }
if (lcremove == NULL) if (lcremove == NULL)
@@ -1050,13 +1057,13 @@ layout_resize_pane_shrink(struct window *w, struct layout_cell *lc,
size = layout_resize_check(w, lcremove, type); size = layout_resize_check(w, lcremove, type);
if (size != 0) if (size != 0)
break; break;
lcremove = TAILQ_PREV(lcremove, layout_cells, entry); lcremove = layout_cell_get_neighbour_dir(lcremove, 0);
} while (lcremove != NULL); } while (lcremove != NULL);
if (lcremove == NULL) if (lcremove == NULL)
return (0); return (0);
/* And add onto the next cell (from the original cell). */ /* And add onto the next cell (from the original cell). */
lcadd = TAILQ_NEXT(lc, entry); lcadd = layout_cell_get_neighbour_dir(lc, 1);
if (lcadd == NULL) if (lcadd == NULL)
return (0); return (0);