circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2025-12-17 03:56:07 +00:00
Code Issues Projects Releases Wiki Activity

Improve code readability in colour_palette_get and colour_palette_set.

Browse Source 
GitHub issue 4730 from Pavel Roskin.
This commit is contained in:
nicm
2025-12-03 07:41:38 +00:00
parent 820df0f551
commit a28dbe3a59
1 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
colour.c
View File

@@ -1082,22 +1082,22 @@ colour_palette_free(struct colour_palette *p)
/* Get a colour from a palette. */ /* Get a colour from a palette. */
int int
colour_palette_get(struct colour_palette *p, int c) colour_palette_get(struct colour_palette *p, int n)
{ {
if (p == NULL) if (p == NULL)
return (-1); return (-1);
if (c >= 90 && c <= 97) if (n >= 90 && n <= 97)
c = 8 + c - 90; n = 8 + n - 90;
else if (c & COLOUR_FLAG_256) else if (n & COLOUR_FLAG_256)
c &= ~COLOUR_FLAG_256; n &= ~COLOUR_FLAG_256;
else if (c >= 8) else if (n >= 8)
return (-1); return (-1);
if (p->palette != NULL && p->palette[c] != -1) if (p->palette != NULL && p->palette[n] != -1)
return (p->palette[c]); return (p->palette[n]);
if (p->default_palette != NULL && p->default_palette[c] != -1) if (p->default_palette != NULL && p->default_palette[n] != -1)
return (p->default_palette[c]); return (p->default_palette[n]);
return (-1); return (-1);
} }
@@ -1107,15 +1107,14 @@ colour_palette_set(struct colour_palette *p, int n, int c)
{ {
u_int i; u_int i;
if (p == NULL || n > 255) if (p == NULL || n < 0 || n > 255)
return (0); return (0);
if (c == -1 && p->palette == NULL) if (c == -1 && p->palette == NULL)
return (0); return (0);
if (c != -1 && p->palette == NULL) { if (p->palette == NULL) {
if (p->palette == NULL) p->palette = xcalloc(256, sizeof *p->palette);
p->palette = xcalloc(256, sizeof *p->palette);
for (i = 0; i < 256; i++) for (i = 0; i < 256; i++)
p->palette[i] = -1; p->palette[i] = -1;
} }