circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2025-09-02 05:21:10 +00:00
Code Issues Projects Releases Wiki Activity

Instead of forbidding invalid session names, sanitize them.

Browse Source
This commit is contained in:
Nicholas Marriott
2020-04-24 16:40:10 +01:00
parent 527f66ed23
commit 9b571dacee
4 changed files with 32 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
session.c
View File

@ -122,7 +122,6 @@ session_create(const char *prefix, const char *name, const char *cwd,
s->cwd = xstrdup(cwd);
s->curw = NULL;
TAILQ_INIT(&s->lastw);
RB_INIT(&s->windows);
@ -141,7 +140,6 @@ session_create(const char *prefix, const char *name, const char *cwd,
s->name = xstrdup(name);
s->id = next_session_id++;
} else {
s->name = NULL;
do {
s->id = next_session_id++;
free(s->name);
@ -231,11 +229,20 @@ session_destroy(struct session *s, int notify, const char *from)
session_remove_ref(s, __func__);
}
/* Check a session name is valid: not empty and no colons or periods. */
int
/* Sanitize session name. */
char *
session_check_name(const char *name)
{
return (*name != '\0' && name[strcspn(name, ":.")] == '\0');
char *copy, *cp, *new_name;
copy = xstrdup(name);
for (cp = copy; *cp != '\0'; cp++) {
if (*cp == ':' || *cp == '.')
*cp = '_';
}
utf8_stravis(&new_name, copy, VIS_OCTAL|VIS_CSTYLE|VIS_TAB|VIS_NL);
free(copy);
return (new_name);
}
/* Lock session if it has timed out. */
@ -555,6 +562,7 @@ session_group_remove(struct session *s)
TAILQ_REMOVE(&sg->sessions, s, gentry);
if (TAILQ_EMPTY(&sg->sessions)) {
RB_REMOVE(session_groups, &session_groups, sg);
free((void *)sg->name);
free(sg);
}
}