Make session_has return a flag, returning the first winlink found is a

recipe for errors.
This commit is contained in:
nicm 2015-04-22 15:32:33 +00:00
parent 8d66f4fba4
commit 9a453dd354
4 changed files with 7 additions and 7 deletions

View File

@ -104,7 +104,7 @@ recalculate_sizes(void)
if (flag)
has = s->curw->window == w;
else
has = session_has(s, w) != NULL;
has = session_has(s, w);
if (has) {
if (s->sx < ssx)
ssx = s->sx;

View File

@ -199,7 +199,7 @@ server_status_window(struct window *w)
*/
RB_FOREACH(s, sessions, &sessions) {
if (session_has(s, w) != NULL)
if (session_has(s, w))
server_status_session(s);
}
}
@ -268,7 +268,7 @@ server_kill_window(struct window *w)
s = next_s;
next_s = RB_NEXT(sessions, &sessions, s);
if (session_has(s, w) == NULL)
if (!session_has(s, w))
continue;
server_unzoom_window(w);
while ((wl = winlink_find_by_window(&s->windows, w)) != NULL) {

View File

@ -309,16 +309,16 @@ session_detach(struct session *s, struct winlink *wl)
}
/* Return if session has window. */
struct winlink *
int
session_has(struct session *s, struct window *w)
{
struct winlink *wl;
RB_FOREACH(wl, winlinks, &s->windows) {
if (wl->window == w)
return (wl);
return (1);
}
return (NULL);
return (0);
}
struct winlink *

2
tmux.h
View File

@ -2321,7 +2321,7 @@ struct winlink *session_new(struct session *, const char *, int, char **,
struct winlink *session_attach(struct session *, struct window *, int,
char **);
int session_detach(struct session *, struct winlink *);
struct winlink *session_has(struct session *, struct window *);
int session_has(struct session *, struct window *);
int session_next(struct session *, int);
int session_previous(struct session *, int);
int session_select(struct session *, int);