Use a stack for last panes line windows, from Thomas Bertschinger in

GitHub issue 3588.
This commit is contained in:
nicm
2023-07-10 09:24:53 +00:00
parent b7e22d00b4
commit 8b3e2eab5a
7 changed files with 59 additions and 26 deletions

View File

@ -248,21 +248,15 @@ winlink_stack_push(struct winlink_stack *stack, struct winlink *wl)
winlink_stack_remove(stack, wl);
TAILQ_INSERT_HEAD(stack, wl, sentry);
wl->flags |= WINLINK_VISITED;
}
void
winlink_stack_remove(struct winlink_stack *stack, struct winlink *wl)
{
struct winlink *wl2;
if (wl == NULL)
return;
TAILQ_FOREACH(wl2, stack, sentry) {
if (wl2 == wl) {
TAILQ_REMOVE(stack, wl, sentry);
return;
}
if (wl != NULL && (wl->flags & WINLINK_VISITED)) {
TAILQ_REMOVE(stack, wl, sentry);
wl->flags &= ~WINLINK_VISITED;
}
}
@ -312,6 +306,7 @@ window_create(u_int sx, u_int sy, u_int xpixel, u_int ypixel)
w->flags = 0;
TAILQ_INIT(&w->panes);
TAILQ_INIT(&w->last_panes);
w->active = NULL;
w->lastlayout = -1;
@ -512,18 +507,23 @@ window_pane_update_focus(struct window_pane *wp)
int
window_set_active_pane(struct window *w, struct window_pane *wp, int notify)
{
struct window_pane *lastwp;
log_debug("%s: pane %%%u", __func__, wp->id);
if (wp == w->active)
return (0);
w->last = w->active;
lastwp = w->active;
window_pane_stack_remove(&w->last_panes, wp);
window_pane_stack_push(&w->last_panes, lastwp);
w->active = wp;
w->active->active_point = next_active_point++;
w->active->flags |= PANE_CHANGED;
if (options_get_number(global_options, "focus-events")) {
window_pane_update_focus(w->last);
window_pane_update_focus(lastwp);
window_pane_update_focus(w->active);
}
@ -746,21 +746,21 @@ window_lost_pane(struct window *w, struct window_pane *wp)
if (wp == marked_pane.wp)
server_clear_marked();
window_pane_stack_remove(&w->last_panes, wp);
if (wp == w->active) {
w->active = w->last;
w->last = NULL;
w->active = TAILQ_FIRST(&w->last_panes);
if (w->active == NULL) {
w->active = TAILQ_PREV(wp, window_panes, entry);
if (w->active == NULL)
w->active = TAILQ_NEXT(wp, entry);
}
if (w->active != NULL) {
window_pane_stack_remove(&w->last_panes, w->active);
w->active->flags |= PANE_CHANGED;
notify_window("window-pane-changed", w);
window_update_focus(w);
}
} else if (wp == w->last)
w->last = NULL;
}
}
void
@ -844,6 +844,11 @@ window_destroy_panes(struct window *w)
{
struct window_pane *wp;
while (!TAILQ_EMPTY(&w->last_panes)) {
wp = TAILQ_FIRST(&w->last_panes);
window_pane_stack_remove(&w->last_panes, wp);
}
while (!TAILQ_EMPTY(&w->panes)) {
wp = TAILQ_FIRST(&w->panes);
TAILQ_REMOVE(&w->panes, wp, entry);
@ -1478,6 +1483,25 @@ window_pane_find_right(struct window_pane *wp)
return (best);
}
void
window_pane_stack_push(struct window_panes *stack, struct window_pane *wp)
{
if (wp != NULL) {
window_pane_stack_remove(stack, wp);
TAILQ_INSERT_HEAD(stack, wp, sentry);
wp->flags |= PANE_VISITED;
}
}
void
window_pane_stack_remove(struct window_panes *stack, struct window_pane *wp)
{
if (wp != NULL && (wp->flags & PANE_VISITED)) {
TAILQ_REMOVE(stack, wp, sentry);
wp->flags &= ~PANE_VISITED;
}
}
/* Clear alert flags for a winlink */
void
winlink_clear_flags(struct winlink *wl)