Fix error handling in if-shell.

This commit is contained in:
nicm 2019-05-25 07:15:53 +00:00
parent 930245d7ff
commit 6b0fa14470

View File

@ -159,7 +159,7 @@ cmd_if_shell_callback(struct job *job)
struct cmd_if_shell_data *cdata = job_get_data(job); struct cmd_if_shell_data *cdata = job_get_data(job);
struct client *c = cdata->client; struct client *c = cdata->client;
struct mouse_event *m = &cdata->mouse; struct mouse_event *m = &cdata->mouse;
struct cmdq_item *new_item; struct cmdq_item *new_item = NULL;
char *cmd; char *cmd;
int status; int status;
struct cmd_parse_result *pr; struct cmd_parse_result *pr;
@ -175,10 +175,10 @@ cmd_if_shell_callback(struct job *job)
pr = cmd_parse_from_string(cmd, &cdata->input); pr = cmd_parse_from_string(cmd, &cdata->input);
switch (pr->status) { switch (pr->status) {
case CMD_PARSE_EMPTY: case CMD_PARSE_EMPTY:
new_item = NULL;
break; break;
case CMD_PARSE_ERROR: case CMD_PARSE_ERROR:
new_item = cmdq_get_error(pr->error); if (cdata->item != NULL)
cmdq_error(cdata->item, "%s", pr->error);
free(pr->error); free(pr->error);
break; break;
case CMD_PARSE_SUCCESS: case CMD_PARSE_SUCCESS: