Allow floating panes to be created partially off the window, based on a

change from Michael Grant.
This commit is contained in:
nicm
2026-06-07 09:54:25 +00:00
parent c9e22ab67b
commit 5744021ac9
3 changed files with 9 additions and 9 deletions

View File

@@ -94,7 +94,7 @@ cmd_join_pane_exec(struct cmd *self, struct cmdq_item *item)
lc = layout_get_tiled_cell(item, args, dst_w, dst_wp, flags, &cause); lc = layout_get_tiled_cell(item, args, dst_w, dst_wp, flags, &cause);
if (cause != NULL) { if (cause != NULL) {
cmdq_error(item, "%s", cause); cmdq_error(item, "size or position %s", cause);
free(cause); free(cause);
return (CMD_RETURN_ERROR); return (CMD_RETURN_ERROR);
} }

View File

@@ -109,7 +109,7 @@ cmd_split_window_exec(struct cmd *self, struct cmdq_item *item)
else else
lc = layout_get_tiled_cell(item, args, w, wp, flags, &cause); lc = layout_get_tiled_cell(item, args, w, wp, flags, &cause);
if (cause != NULL) { if (cause != NULL) {
cmdq_error(item, "%s", cause); cmdq_error(item, "size or position %s", cause);
free(cause); free(cause);
return (CMD_RETURN_ERROR); return (CMD_RETURN_ERROR);
} }

View File

@@ -1359,30 +1359,30 @@ layout_get_floating_cell(struct cmdq_item *item, struct args *args,
struct window *w, __unused struct window_pane *wp, char **cause) struct window *w, __unused struct window_pane *wp, char **cause)
{ {
struct layout_cell *lcnew; struct layout_cell *lcnew;
u_int sx = w->sx / 2, sy = w->sy / 4; int sx = w->sx / 2, sy = w->sy / 4;
int ox = INT_MAX, oy = INT_MAX; int ox = INT_MAX, oy = INT_MAX;
if (args_has(args, 'x')) { if (args_has(args, 'x')) {
sx = args_percentage_and_expand(args, 'x', 0, USHRT_MAX, w->sx, sx = args_percentage_and_expand(args, 'x', 0, w->sx - 1, w->sx,
item, cause); item, cause);
if (*cause != NULL) if (*cause != NULL)
return (NULL); return (NULL);
} }
if (args_has(args, 'y')) { if (args_has(args, 'y')) {
sy = args_percentage_and_expand(args, 'y', 0, USHRT_MAX, w->sy, sy = args_percentage_and_expand(args, 'y', 0, w->sy - 1, w->sy,
item, cause); item, cause);
if (*cause != NULL) if (*cause != NULL)
return (NULL); return (NULL);
} }
if (args_has(args, 'X')) { if (args_has(args, 'X')) {
ox = args_percentage_and_expand(args, 'X', 0, USHRT_MAX, w->sx, ox = args_percentage_and_expand(args, 'X', -sx, w->sx,
item, cause); w->sx, item, cause);
if (*cause != NULL) if (*cause != NULL)
return (NULL); return (NULL);
} }
if (args_has(args, 'Y')) { if (args_has(args, 'Y')) {
oy = args_percentage_and_expand(args, 'Y', 0, USHRT_MAX, w->sy, oy = args_percentage_and_expand(args, 'Y', -sy, w->sy,
item, cause); w->sy, item, cause);
if (*cause != NULL) if (*cause != NULL)
return (NULL); return (NULL);
} }