circlecloud
/
tmux
mirror of https://github.com/tmux/tmux.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

When given an invalid style, don't set the option to the default. Fix 

from J Raynor. Also make style_parse not alter the grid_cell when it
fails.
pull/1/head
nicm 2015-02-18 15:32:37 +00:00
parent 4d05d88304
commit 568f5ef3c6
2 changed files with 28 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
options.c
View File

@ -167,20 +167,26 @@ options_set_style(struct options *oo, const char *name, const char *value,
int append)
{
struct options_entry *o;
struct grid_cell tmpgc;
if ((o = options_find1(oo, name)) == NULL) {
o = options_find1(oo, name);
if (o == NULL || !append)
memcpy(&tmpgc, &grid_default_cell, sizeof tmpgc);
else
memcpy(&tmpgc, &o->style, sizeof tmpgc);
if (style_parse(&grid_default_cell, &tmpgc, value) == -1)
return (NULL);
if (o == NULL) {
o = xmalloc(sizeof *o);
o->name = xstrdup(name);
RB_INSERT(options_tree, &oo->tree, o);
} else if (o->type == OPTIONS_STRING)
free(o->str);
if (!append)
memcpy(&o->style, &grid_default_cell, sizeof o->style);
o->type = OPTIONS_STYLE;
if (style_parse(&grid_default_cell, &o->style, value) == -1)
return (NULL);
memcpy(&o->style, &tmpgc, sizeof o->style);
return (o);
}

26
style.c
View File

@ -28,16 +28,18 @@ int
style_parse(const struct grid_cell *defgc, struct grid_cell *gc,
const char *in)
{
const char delimiters[] = " ,";
char tmp[32];
int val;
size_t end;
u_char fg, bg, attr, flags;
struct grid_cell savedgc;
const char delimiters[] = " ,";
char tmp[32];
int val;
size_t end;
u_char fg, bg, attr, flags;
if (*in == '\0')
return (0);
if (strchr(delimiters, in[strlen(in) - 1]) != NULL)
return (-1);
memcpy(&savedgc, gc, sizeof savedgc);
fg = gc->fg;
bg = gc->bg;
@ -46,7 +48,7 @@ style_parse(const struct grid_cell *defgc, struct grid_cell *gc,
do {
end = strcspn(in, delimiters);
if (end > (sizeof tmp) - 1)
return (-1);
goto error;
memcpy(tmp, in, end);
tmp[end] = '\0';
@ -59,7 +61,7 @@ style_parse(const struct grid_cell *defgc, struct grid_cell *gc,
defgc->flags & (GRID_FLAG_FG256|GRID_FLAG_BG256);
} else if (end > 3 && strncasecmp(tmp + 1, "g=", 2) == 0) {
if ((val = colour_fromstring(tmp + 3)) == -1)
return (-1);
goto error;
if (*in == 'f' || *in == 'F') {
if (val != 8) {
if (val & 0x100) {
@ -87,16 +89,16 @@ style_parse(const struct grid_cell *defgc, struct grid_cell *gc,
flags |= defgc->flags & GRID_FLAG_BG256;
}
} else
return (-1);
goto error;
} else if (strcasecmp(tmp, "none") == 0)
attr = 0;
else if (end > 2 && strncasecmp(tmp, "no", 2) == 0) {
if ((val = attributes_fromstring(tmp + 2)) == -1)
return (-1);
goto error;
attr &= ~val;
} else {
if ((val = attributes_fromstring(tmp)) == -1)
return (-1);
goto error;
attr |= val;
}
@ -108,6 +110,10 @@ style_parse(const struct grid_cell *defgc, struct grid_cell *gc,
gc->flags = flags;
return (0);
error:
memcpy(gc, &savedgc, sizeof *gc);
return (-1);
}
/* Convert style to a string. */