circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2025-09-03 14:27:09 +00:00
Code Issues Projects Releases Wiki Activity

Reference count clients and sessions rather than relying on a saved index for

Browse Source 
cmd-choose-*.
This commit is contained in:
Nicholas Marriott
2009-09-07 21:01:50 +00:00
parent e323f6620d
commit 51c95747d8
7 changed files with 106 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cmd-choose-session.c
View File

@ -43,7 +43,7 @@ const struct cmd_entry cmd_choose_session_entry = {
};
struct cmd_choose_session_data {
u_int client;
struct client *client;
char *template;
};
@ -87,7 +87,8 @@ cmd_choose_session_exec(struct cmd *self, struct cmd_ctx *ctx)
cdata->template = xstrdup(data->arg);
else
cdata->template = xstrdup("switch-client -t '%%'");
cdata->client = server_client_index(ctx->curclient);
cdata->client = ctx->curclient;
cdata->client->references++;
window_choose_ready(wl->window->active,
cur, cmd_choose_session_callback, cmd_choose_session_free, cdata);
@ -99,7 +100,6 @@ void
cmd_choose_session_callback(void *data, int idx)
{
struct cmd_choose_session_data *cdata = data;
struct client *c;
struct session *s;
struct cmd_list *cmdlist;
struct cmd_ctx ctx;
@ -107,9 +107,8 @@ cmd_choose_session_callback(void *data, int idx)
if (idx == -1)
return;
if (cdata->client > ARRAY_LENGTH(&clients) - 1)
if (cdata->client->flags & CLIENT_DEAD)
return;
c = ARRAY_ITEM(&clients, cdata->client);
if ((u_int) idx > ARRAY_LENGTH(&sessions) - 1)
return;
@ -121,7 +120,7 @@ cmd_choose_session_callback(void *data, int idx)
if (cmd_string_parse(template, &cmdlist, &cause) != 0) {
if (cause != NULL) {
*cause = toupper((u_char) *cause);
status_message_set(c, "%s", cause);
status_message_set(cdata->client, "%s", cause);
xfree(cause);
}
xfree(template);
@ -130,7 +129,7 @@ cmd_choose_session_callback(void *data, int idx)
xfree(template);
ctx.msgdata = NULL;
ctx.curclient = c;
ctx.curclient = cdata->client;
ctx.error = key_bindings_error;
ctx.print = key_bindings_print;
@ -147,6 +146,7 @@ cmd_choose_session_free(void *data)
{
struct cmd_choose_session_data *cdata = data;
cdata->client->references--;
xfree(cdata->template);
xfree(cdata);
}