Add a TTY_OPENED flag and tidy a little.

pull/1/head
Nicholas Marriott 2009-08-11 20:29:04 +00:00
parent ff65e37545
commit 4ec8ade11c
2 changed files with 18 additions and 17 deletions

1
tmux.h
View File

@ -869,6 +869,7 @@ struct tty {
#define TTY_ESCAPE 0x4 #define TTY_ESCAPE 0x4
#define TTY_UTF8 0x8 #define TTY_UTF8 0x8
#define TTY_STARTED 0x10 #define TTY_STARTED 0x10
#define TTY_OPENED 0x20
int flags; int flags;
int term_flags; int term_flags;

34
tty.c
View File

@ -80,8 +80,11 @@ tty_open(struct tty *tty, const char *overrides, char **cause)
tty->log_fd = -1; tty->log_fd = -1;
tty->term = tty_term_find(tty->termname, tty->fd, overrides, cause); tty->term = tty_term_find(tty->termname, tty->fd, overrides, cause);
if (tty->term == NULL) if (tty->term == NULL) {
goto error; tty_close(tty);
return (-1);
}
tty->flags |= TTY_OPENED;
tty->in = buffer_create(BUFSIZ); tty->in = buffer_create(BUFSIZ);
tty->out = buffer_create(BUFSIZ); tty->out = buffer_create(BUFSIZ);
@ -95,12 +98,6 @@ tty_open(struct tty *tty, const char *overrides, char **cause)
tty_fill_acs(tty); tty_fill_acs(tty);
return (0); return (0);
error:
close(tty->fd);
tty->fd = -1;
return (-1);
} }
void void
@ -289,9 +286,6 @@ tty_get_acs(struct tty *tty, u_char ch)
void void
tty_close(struct tty *tty) tty_close(struct tty *tty)
{ {
if (tty->fd == -1)
return;
if (tty->log_fd != -1) { if (tty->log_fd != -1) {
close(tty->log_fd); close(tty->log_fd);
tty->log_fd = -1; tty->log_fd = -1;
@ -299,14 +293,20 @@ tty_close(struct tty *tty)
tty_stop_tty(tty); tty_stop_tty(tty);
tty_term_free(tty->term); if (tty->flags & TTY_OPENED) {
tty_keys_free(tty); tty_term_free(tty->term);
tty_keys_free(tty);
close(tty->fd); buffer_destroy(tty->in);
tty->fd = -1; buffer_destroy(tty->out);
buffer_destroy(tty->in); tty->flags &= ~TTY_OPENED;
buffer_destroy(tty->out); }
if (tty->fd != -1) {
close(tty->fd);
tty->fd = -1;
}
} }
void void