From 4ce893ebc0f61c24b06b9350186f5048661f00e2 Mon Sep 17 00:00:00 2001 From: nicm Date: Thu, 14 Aug 2025 06:37:29 +0000 Subject: [PATCH] Do not leak opened file, from lg65438805 at gmail dot com in GitHub issue 4577. --- file.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/file.c b/file.c index 91698a4c..988ac7dd 100644 --- a/file.c +++ b/file.c @@ -364,7 +364,7 @@ file_read(struct client *c, const char *path, client_file_cb cb, void *cbdata) size_t msglen; int fd = -1; u_int stream = file_next_stream++; - FILE *f; + FILE *f = NULL; size_t size; char buffer[BUFSIZ]; @@ -404,7 +404,6 @@ file_read(struct client *c, const char *path, client_file_cb cb, void *cbdata) cf->error = EIO; goto done; } - fclose(f); goto done; } @@ -427,6 +426,8 @@ skip: return cf; done: + if (f != NULL) + fclose(f); file_fire_done(cf); return NULL; }