mirror of
				https://github.com/tmux/tmux.git
				synced 2025-11-04 00:56:10 +00:00 
			
		
		
		
	Instead of every command resolving the target (-t or -s) itself, prepare
the state (client, session, winlink, pane) for it it before entering the command. Each command provides some flags that tell the prepare step what it is expecting. This is a requirement for having hooks on commands (for example, if you hook "select-window -t1:2", the hook command should to operate on window 1:2 not whatever it thinks is the current window), and should allow some other target improvements. The old cmd_find_* functions remain for the moment but that layer will be dropped later. Joint work with Thomas Adam.
This commit is contained in:
		@@ -37,7 +37,7 @@ const struct cmd_entry cmd_join_pane_entry = {
 | 
			
		||||
	"join-pane", "joinp",
 | 
			
		||||
	"bdhvp:l:s:t:", 0, 0,
 | 
			
		||||
	"[-bdhv] [-p percentage|-l size] " CMD_SRCDST_PANE_USAGE,
 | 
			
		||||
	0,
 | 
			
		||||
	CMD_PANE_MARKED_S|CMD_PANE_T,
 | 
			
		||||
	cmd_join_pane_exec
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
@@ -45,7 +45,7 @@ const struct cmd_entry cmd_move_pane_entry = {
 | 
			
		||||
	"move-pane", "movep",
 | 
			
		||||
	"bdhvp:l:s:t:", 0, 0,
 | 
			
		||||
	"[-bdhv] [-p percentage|-l size] " CMD_SRCDST_PANE_USAGE,
 | 
			
		||||
	0,
 | 
			
		||||
	CMD_PANE_S|CMD_PANE_T,
 | 
			
		||||
	cmd_join_pane_exec
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
@@ -68,16 +68,15 @@ join_pane(struct cmd *self, struct cmd_q *cmdq, int not_same_window)
 | 
			
		||||
	enum layout_type	 type;
 | 
			
		||||
	struct layout_cell	*lc;
 | 
			
		||||
 | 
			
		||||
	dst_wl = cmd_find_pane(cmdq, args_get(args, 't'), &dst_s, &dst_wp);
 | 
			
		||||
	if (dst_wl == NULL)
 | 
			
		||||
		return (CMD_RETURN_ERROR);
 | 
			
		||||
	dst_s = cmdq->state.tflag.s;
 | 
			
		||||
	dst_wl = cmdq->state.tflag.wl;
 | 
			
		||||
	dst_wp = cmdq->state.tflag.wp;
 | 
			
		||||
	dst_w = dst_wl->window;
 | 
			
		||||
	dst_idx = dst_wl->idx;
 | 
			
		||||
	server_unzoom_window(dst_w);
 | 
			
		||||
 | 
			
		||||
	src_wl = cmd_find_pane_marked(cmdq, args_get(args, 's'), NULL, &src_wp);
 | 
			
		||||
	if (src_wl == NULL)
 | 
			
		||||
		return (CMD_RETURN_ERROR);
 | 
			
		||||
	src_wl = cmdq->state.sflag.wl;
 | 
			
		||||
	src_wp = cmdq->state.sflag.wp;
 | 
			
		||||
	src_w = src_wl->window;
 | 
			
		||||
	server_unzoom_window(src_w);
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user