mirror of
				https://github.com/tmux/tmux.git
				synced 2025-11-04 09:26:05 +00:00 
			
		
		
		
	Instead of every command resolving the target (-t or -s) itself, prepare
the state (client, session, winlink, pane) for it it before entering the command. Each command provides some flags that tell the prepare step what it is expecting. This is a requirement for having hooks on commands (for example, if you hook "select-window -t1:2", the hook command should to operate on window 1:2 not whatever it thinks is the current window), and should allow some other target improvements. The old cmd_find_* functions remain for the moment but that layer will be dropped later. Joint work with Thomas Adam.
This commit is contained in:
		@@ -51,7 +51,7 @@ const struct cmd_entry cmd_find_window_entry = {
 | 
			
		||||
	"find-window", "findw",
 | 
			
		||||
	"F:CNt:T", 1, 4,
 | 
			
		||||
	"[-CNT] [-F format] " CMD_TARGET_WINDOW_USAGE " match-string",
 | 
			
		||||
	0,
 | 
			
		||||
	CMD_WINDOW_T,
 | 
			
		||||
	cmd_find_window_exec
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
@@ -137,10 +137,10 @@ enum cmd_retval
 | 
			
		||||
cmd_find_window_exec(struct cmd *self, struct cmd_q *cmdq)
 | 
			
		||||
{
 | 
			
		||||
	struct args			*args = self->args;
 | 
			
		||||
	struct client			*c;
 | 
			
		||||
	struct client			*c = cmdq->state.c;
 | 
			
		||||
	struct window_choose_data	*cdata;
 | 
			
		||||
	struct session			*s;
 | 
			
		||||
	struct winlink			*wl, *wm;
 | 
			
		||||
	struct session			*s = cmdq->state.tflag.s;
 | 
			
		||||
	struct winlink			*wl = cmdq->state.tflag.wl, *wm;
 | 
			
		||||
	struct cmd_find_window_list	 find_list;
 | 
			
		||||
	struct cmd_find_window_data	*find_data;
 | 
			
		||||
	struct cmd_find_window_data	*find_data1;
 | 
			
		||||
@@ -148,14 +148,10 @@ cmd_find_window_exec(struct cmd *self, struct cmd_q *cmdq)
 | 
			
		||||
	const char			*template;
 | 
			
		||||
	u_int				 i, match_flags;
 | 
			
		||||
 | 
			
		||||
	if ((c = cmd_find_client(cmdq, NULL, 1)) == NULL) {
 | 
			
		||||
	if (c == NULL) {
 | 
			
		||||
		cmdq_error(cmdq, "no client available");
 | 
			
		||||
		return (CMD_RETURN_ERROR);
 | 
			
		||||
	}
 | 
			
		||||
	s = c->session;
 | 
			
		||||
 | 
			
		||||
	if ((wl = cmd_find_window(cmdq, args_get(args, 't'), NULL)) == NULL)
 | 
			
		||||
		return (CMD_RETURN_ERROR);
 | 
			
		||||
 | 
			
		||||
	if ((template = args_get(args, 'F')) == NULL)
 | 
			
		||||
		template = FIND_WINDOW_TEMPLATE;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user