From 29a5931c6a352f12fe4bcc1cb72cb96e073ddca6 Mon Sep 17 00:00:00 2001 From: Nicholas Marriott Date: Mon, 30 Nov 2009 16:44:03 +0000 Subject: [PATCH] Handle partial xterm function key sequences. --- tmux.h | 2 +- tty-keys.c | 9 ++++++--- xterm-keys.c | 37 +++++++++++++++++++++++++------------ 3 files changed, 32 insertions(+), 16 deletions(-) diff --git a/tmux.h b/tmux.h index 62f753da..e29bb015 100644 --- a/tmux.h +++ b/tmux.h @@ -1647,7 +1647,7 @@ void input_mouse(struct window_pane *, struct mouse_event *); /* xterm-keys.c */ char *xterm_keys_lookup(int); -int xterm_keys_find(const char *, size_t, size_t *); +int xterm_keys_find(const char *, size_t, size_t *, int *); /* colour.c */ void colour_set_fg(struct grid_cell *, int); diff --git a/tty-keys.c b/tty-keys.c index 8f90b6ec..1319e09f 100644 --- a/tty-keys.c +++ b/tty-keys.c @@ -472,12 +472,15 @@ tty_keys_next(struct tty *tty) goto partial_key; } - /* Not found. Try to parse a key with an xterm-style modifier. */ - key = xterm_keys_find(buf, len, &size); - if (key != KEYC_NONE) { + switch (xterm_keys_find(buf, len, &size, &key)) { + case 0: /* found */ evbuffer_drain(tty->event->input, size); goto handle_key; + case -1: /* not found */ + break; + case 1: + goto partial_key; } /* Skip the escape. */ diff --git a/xterm-keys.c b/xterm-keys.c index ca94a1f6..f0fbf802 100644 --- a/xterm-keys.c +++ b/xterm-keys.c @@ -85,22 +85,28 @@ struct xterm_keys_entry xterm_keys_table[] = { { KEYC_DC, "\033[3;_~" }, }; -/* Match key against buffer, treating _ as a wildcard. */ +/* + * Match key against buffer, treating _ as a wildcard. Return -1 for no match, + * 0 for match, 1 if the end of the buffer is reached (need more data). + */ int xterm_keys_match(const char *template, const char *buf, size_t len) { size_t pos; - if (len == 0 || len < strlen(template)) + if (len == 0) return (0); pos = 0; do { if (*template != '_' && buf[pos] != *template) - return (0); + return (-1); } while (pos++ != len && *++template != '\0'); - return (1); + if (*template != '\0') /* partial */ + return (1); + + return (0); } /* Find modifiers based on template. */ @@ -131,22 +137,29 @@ xterm_keys_modifiers(const char *template, const char *buf, size_t len) return (0); } -/* Lookup key from buffer against table. */ +/* + * Lookup key from a buffer against the table. Returns 0 for found (and the + * key), -1 for not found, 1 for partial match. + */ int -xterm_keys_find(const char *buf, size_t len, size_t *size) +xterm_keys_find(const char *buf, size_t len, size_t *size, int *key) { struct xterm_keys_entry *entry; u_int i; for (i = 0; i < nitems(xterm_keys_table); i++) { entry = &xterm_keys_table[i]; - if (xterm_keys_match(entry->template, buf, len)) - break; + switch (xterm_keys_match(entry->template, buf, len)) { + case 0: + *size = strlen(entry->template); + *key = entry->key; + *key |= xterm_keys_modifiers(entry->template, buf, len); + return (0); + case 1: + return (1); + } } - if (i == nitems(xterm_keys_table)) - return (KEYC_NONE); - *size = strlen(entry->template); - return (entry->key | xterm_keys_modifiers(entry->template, buf, len)); + return (-1); } /* Lookup a key number from the table. */