circlecloud/tmux
1
0
Fork 0
mirror of https://github.com/tmux/tmux.git synced 2025-01-15 05:09:04 +00:00
Code Issues Projects Releases Wiki Activity

Copy was using the real line length which after resize can be larger than the

Browse Source 
screen width. When built with -DDEBUG, this made the grid bounds checking code
kill the server. Restrict copying to the actual width.

From Kalle Olavi Niemitalo, thanks.
This commit is contained in:
Nicholas Marriott 2009-07-11 19:09:24 +00:00
parent 4cbbbddf22
commit 289320a9b1
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
window-copy.c
View File

@ -522,7 +522,15 @@ window_copy_find_length(struct window_pane *wp, u_int py)
const struct grid_cell *gc; const struct grid_cell *gc;
u_int px; u_int px;
/*
* If the pane has been resized, its grid can contain old overlong
* lines. grid_peek_cell does not allow accessing cells beyond the
* width of the grid, and screen_write_copy treats them as spaces, so
* ignore them here too.
*/
px = wp->base.grid->size[py]; px = wp->base.grid->size[py];
if (px > screen_size_x(&wp->base))
px = screen_size_x(&wp->base);
while (px > 0) { while (px > 0) {
gc = grid_peek_cell(wp->base.grid, px - 1, py); gc = grid_peek_cell(wp->base.grid, px - 1, py);
if (gc->flags & GRID_FLAG_UTF8) if (gc->flags & GRID_FLAG_UTF8)