Simplify width calculation (all numbers always sequential) and don't

rely on uninitialized data, from Thomas Adam.
This commit is contained in:
Nicholas Marriott 2012-08-12 06:22:26 +00:00
parent a194430e5d
commit 20129b7bf9

View File

@ -80,7 +80,6 @@ window_choose_add(struct window_pane *wp, struct window_choose_data *wcd)
{ {
struct window_choose_mode_data *data = wp->modedata; struct window_choose_mode_data *data = wp->modedata;
struct window_choose_mode_item *item; struct window_choose_mode_item *item;
int width;
char tmp[10]; char tmp[10];
ARRAY_EXPAND(&data->list, 1); ARRAY_EXPAND(&data->list, 1);
@ -90,9 +89,7 @@ window_choose_add(struct window_pane *wp, struct window_choose_data *wcd)
item->wcd = wcd; item->wcd = wcd;
item->pos = ARRAY_LENGTH(&data->list) - 1; item->pos = ARRAY_LENGTH(&data->list) - 1;
width = snprintf (tmp, sizeof tmp, "%u", item->pos); data->width = snprintf (tmp, sizeof tmp , "%u", item->pos);
if (width > data->width)
data->width = width;
} }
void void