From 0f9e0d1cfe645f276ef471131b55e9bfe2276758 Mon Sep 17 00:00:00 2001 From: Nicholas Marriott Date: Mon, 23 Apr 2012 22:43:09 +0000 Subject: [PATCH] Do not return a buffer on the stack, mentioned by jsg a while ago. --- cmd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd.c b/cmd.c index 5d8e7209..a3a70284 100644 --- a/cmd.c +++ b/cmd.c @@ -1325,8 +1325,10 @@ find_home: return (s->cwd); complete_path: - if (root[skip] == '\0') - return (root); + if (root[skip] == '\0') { + strlcpy(path, root, sizeof path); + return (path); + } n = snprintf(path, sizeof path, "%s/%s", root, cwd + skip); if (n > 0 && (size_t)n < sizeof path) return (path);