From 9bab73f48991f7f200f209a95d6a95e44f5769d0 Mon Sep 17 00:00:00 2001 From: nicm Date: Mon, 3 Sep 2018 08:47:27 +0000 Subject: [PATCH 1/2] Fix selection test, from Takeshi Banse. --- window-copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/window-copy.c b/window-copy.c index 6ef4b29d..39bf2c2e 100644 --- a/window-copy.c +++ b/window-copy.c @@ -2082,7 +2082,7 @@ window_copy_cursor_up(struct window_pane *wp, int scroll_only) } } - if (data->screen.sel != NULL || !data->rectflag) { + if (data->screen.sel == NULL || !data->rectflag) { py = screen_hsize(data->backing) + data->cy - data->oy; px = window_copy_find_length(wp, py); if ((data->cx >= data->lastsx && data->cx != px) || From 8f9491ddfe525f8ac32175871d269d0fb4adebc3 Mon Sep 17 00:00:00 2001 From: nicm Date: Mon, 3 Sep 2018 08:51:43 +0000 Subject: [PATCH 2/2] Allow a large line number to go to the end with goto-line, from Mark Kelly in GitHub issue 1460. --- window-copy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/window-copy.c b/window-copy.c index 39bf2c2e..660eb63c 100644 --- a/window-copy.c +++ b/window-copy.c @@ -1273,11 +1273,13 @@ window_copy_goto_line(struct window_pane *wp, const char *linestr) { struct window_copy_mode_data *data = wp->modedata; const char *errstr; - u_int lineno; + int lineno; - lineno = strtonum(linestr, 0, screen_hsize(data->backing), &errstr); + lineno = strtonum(linestr, -1, INT_MAX, &errstr); if (errstr != NULL) return; + if (lineno < 0 || (u_int)lineno > screen_hsize(data->backing)) + lineno = screen_hsize(data->backing); data->oy = lineno; window_copy_update_selection(wp, 1);