From 045d0c3b9f616fe76b68d4551a6d66f410e760e8 Mon Sep 17 00:00:00 2001 From: nicm Date: Wed, 1 Oct 2014 23:23:19 +0000 Subject: [PATCH] Call waitpid on SIGCHLD even if client not attached, it is possible (on very slow platforms) for the first daemon() child to still be running when client_attached is set so we end up with a zombie. From J Raynor. --- client.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/client.c b/client.c index e92724a2..a790f32e 100644 --- a/client.c +++ b/client.c @@ -433,15 +433,11 @@ client_signal(int sig, unused short events, unused void *data) struct sigaction sigact; int status; - if (!client_attached) { - switch (sig) { - case SIGCHLD: - waitpid(WAIT_ANY, &status, WNOHANG); - break; - case SIGTERM: + if (sig == SIGCHLD) + waitpid(WAIT_ANY, &status, WNOHANG); + else if (!client_attached) { + if (sig == SIGTERM) event_loopexit(NULL); - break; - } } else { switch (sig) { case SIGHUP: