circlecloud/ms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

feat: optimize config save logic

Browse Source 
Signed-off-by: MiaoWoo <admin@yumc.pw>
This commit is contained in:
MiaoWoo 2020-10-31 11:40:38 +08:00
parent 3f101ca250
commit 0776d0ddeb
4 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/plugin/src/command.ts
View File

@ -35,8 +35,6 @@ export class PluginCommandManager {
private unregistryCommand(pluginInstance: plugin.Plugin) { private unregistryCommand(pluginInstance: plugin.Plugin) {
let cmds = getPluginCommandMetadata(pluginInstance) let cmds = getPluginCommandMetadata(pluginInstance)
cmds.forEach(cmd => { cmds.forEach(cmd => this.CommandManager.off(pluginInstance, cmd.name))
this.CommandManager.off(pluginInstance, cmd.name)
})
} }
} }

3
packages/plugin/src/config.ts
View File

@ -69,7 +69,7 @@ export class PluginConfigManager {
saveConfig(plugin: plugin.Plugin) { saveConfig(plugin: plugin.Plugin) {
let configs = getPluginConfigMetadata(plugin) let configs = getPluginConfigMetadata(plugin)
for (let [_, config] of configs) { for (let [_, config] of configs) {
this.saveConfig0(plugin, config) config.autosave && this.saveConfig0(plugin, config)
} }
} }
@ -102,7 +102,6 @@ export class PluginConfigManager {
private saveConfig0(plugin: plugin.Plugin, metadata: interfaces.ConfigMetadata) { private saveConfig0(plugin: plugin.Plugin, metadata: interfaces.ConfigMetadata) {
try { try {
if (metadata.readonly) { console.debug(`[${plugin.description.name}] Skip Save Config ${metadata.variable} Because it's readonly!`) }
metadata.file = fs.concat(fs.file(plugin.description.loadMetadata.file).parent, plugin.description.name, metadata.filename) metadata.file = fs.concat(fs.file(plugin.description.loadMetadata.file).parent, plugin.description.name, metadata.filename)
let result = this.getConfigLoader(metadata.format).dump(plugin[metadata.variable]) let result = this.getConfigLoader(metadata.format).dump(plugin[metadata.variable])
base.save(metadata.file, result) base.save(metadata.file, result)

1
packages/plugin/src/decorators.ts
View File

@ -77,6 +77,7 @@ export function config(metadata: interfaces.ConfigMetadata = {}) {
metadata.variable = key metadata.variable = key
metadata.version = metadata.version ?? 1 metadata.version = metadata.version ?? 1
metadata.format = metadata.format ?? 'yml' metadata.format = metadata.format ?? 'yml'
metadata.autosave = metadata.autosave ?? false
metadata.filename = metadata.filename ?? metadata.name + '.' + metadata.format metadata.filename = metadata.filename ?? metadata.name + '.' + metadata.format
let previousMetadata = getPluginConfigMetadata(target) let previousMetadata = getPluginConfigMetadata(target)
previousMetadata.set(metadata.name, metadata) previousMetadata.set(metadata.name, metadata)

4
packages/plugin/src/interfaces.ts
View File

@ -72,9 +72,9 @@ export namespace interfaces {
*/ */
format?: string format?: string
/** /**
* 是否为只读(关闭时将不会自动保存) * 自动保存 默认为 false
*/ */
readonly?: boolean autosave?: boolean
/** /**
* 配置文件名称 * 配置文件名称
*/ */